-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podLabels variable for all daemonsets. #690
Conversation
This will let you add pod labels to the daemonset pods without messing with the selector Labels. Signed-off-by: Geoff Webster <gwebster@aurora.tech>
Thanks a lot @sidewinder12s ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thoughts @elezar ?
Any update @ArangoGutierrez? |
@@ -38,6 +38,7 @@ spec: | |||
metadata: | |||
labels: | |||
{{- include "nvidia-device-plugin.templateLabels" . | nindent 8 }} | |||
{{- toYaml .Values.podLabels | nindent 8 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question. What is the behaviour if these conflict with any labels generated from templateLabels
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should merge and keep the last stated label I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if someone passed in a label the templateLabels variable sets, they will override it.
Anything else required? |
@elezar Can this be merged? |
@ArangoGutierrez Can this be merged? |
This will let you add pod labels to the daemonset pods without messing with the selector labels.
Closes #280